update rtp #2
Open
update rtp #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debian wants rid of .la files, and these module .la files shouldn't be necessary on a Debian system.
Debian wants rid of .la files, and leaving this out shouldn't do any harm on a Debian system.
We're not including the source code or build tools for the version of the player we're distributing, so it fails The Debian Free Software Guidelines (DFSG).
…has the correct perms
* fixed bug with remote hello-hash buffer being too small * removed unused hello-hash storage in zrtp stream context * fixed bug with libzrtp rendered "empty" SAS hash from incoming SasRelay packet * incremented libzrtp version number to 1.15 Signed-off-by: Travis Cross <[email protected]>
Related to issue FS-4293.
This error was causing us to call generate_m with a buffer length that was less than the strlen of the buffer we were passing. The result was truncated local SDP which would cause sofia to fail if the truncation was in a particularly bad place. Thanks to Anthony Minessale for the fix and working with me to diagnose the issue. FS-4293 --resolve
There are a lot of codecs these days, and some clients offer all of them. If we run out of space in this buffer our local SDP will get silently truncated, which will cause a difficult to diagnose error in Sofia-SIP. Thanks to Anthony Minessale. FS-4293 --resolve
…ure for the profile from launch_sofia_worker_thread
The revision was no longer picking up the last git commit. Instead, it was showing the last release. This commit appends the last git commit hash to the last release if a git repository is available. Further, it checks whether there are uncommitted changes in the git repository and adds an unclean tag to the version if this is the case. Note that currently this will append the git commit hash even on a tagged release if built directly from a git repository. Perhaps this isn't such a bad thing, but if it turns out not to be desired, I have an idea on how to squelch this without making unwarranted assumptions about the remote layout of someone's local repository.
…e both endpoints were type 'sofia' and dereferencing dingaling channel into sofia and causing memory corruption
In a sofia profile, you can now set the parameter tls-timeout to a positive integer value which represents the maximum time in seconds that OpenSSL will keep a TLS session (and its ephemeral keys) alive. This value is passed to OpenSSL's SSL_CTX_set_timeout(3). OpenSSL's default value is 300 seconds, but the relevant standard (RFC 2246) suggests that much longer session lifetimes are acceptable (it recommends values less than 24 hours). Longer values can be useful for extending battery life on mobile devices. Signed-off-by: Travis Cross <[email protected]>
…nnected it seems. Undoing this change for now until I can figure out the root cause.
FS-4303 --resolve
…cks deal with the profile not matching the one passed and will do the right thing.
…ne of redundant code.
…for original patch. Fixes FS-4309
This amends commit f8be71a. This still should resolve FS-4303. What's going on here is that we need a portable way to access strftime. date(1posix) doesn't provide enough. And without perl, I can't think of a better way to get to it than just using C. So the logic for generating the extended revision has been moved into a small self-contained and hopefully portable C program.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.