-
Notifications
You must be signed in to change notification settings - Fork 150
Add benchmarks for push, insert, extend, and pushpop #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -5,6 +5,8 @@ | |||
//! Small vectors in various sizes. These store a certain number of elements inline and fall back | |||
//! to the heap for larger allocations. | |||
|
|||
#![feature(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't compile in stable, will it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Let me work on factoring it into a conditionally compiled feature which is disabled by default.
Looks like this on my machine (Mac book pro laptop)
Travis CI looked like this. I don't think we can really rely on its numbers though.
|
Any update on this? |
@bors-servo: r+ |
📌 Commit 951f1d0 has been approved by |
⚡ Test exempted - status |
Add benchmarks for push, insert, extend, and pushpop Want to add these benchmarks so that we can more effectively detect regressions/improvements from PR's like #28 and #29. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-smallvec/31) <!-- Reviewable:end -->
Want to add these benchmarks so that we can more effectively detect regressions/improvements from PR's like #28 and #29.
This change is