Upgrade to SM 109 #340
Closed
Upgrade to SM 109 #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 25, 2023 18:43
Virtualenv has been removed from sm109
Implementation in IonAnalysis has changes. We don't need to refactor that line any more.
JS Streams has been removed from sm109. See https://hg.mozilla.org/mozilla-central/rev/bf1bc477f95d for more information.
|
The issue with the |
|
Yeah, I identified the risk with the streams in servo/servo#29088. I wonder if the best choice would be to rip out streams support in servo, rather than block on the rewrite? |
|
☔ The latest upstream changes (presumably #358) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I believe this is superceded by #408 so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my first attempt to upgrade to spider monkey 109. But there are some issues I might need some advice, so I keep it as a draft for now. Only
mozjs-syshas been built and tested on Linux, macOS, and Windows.On Windows, there are some new config checks need
MOZILLABUILDenv variable. But I couldn't figure out why it didn't call itsmach_initializeto set it. The easiest way is to set it manually like$env:MOZILLABUILD="C:\mozilla-build"for example. Could we add this in CI?JS Streams have been removed. I removed the bindings in sys crate as well, but not
rust-mozjs. Servo's dom implementation is going to be affected too. I'm not sure what I should do starting from here. Could we also remove all bindings and implementation?