Windows#233

Closed

angelortiz1007 wants to merge 113 commits intoservo:masterfrom

angelortiz1007:windows

Commits on Jun 24, 2019

tests: cleanup: Avoid `.pop().unwrap()` in cross_process_sender_transfer()

vvuk
authored and
angelortiz1007
committed
tests: Add variants of cross-process test, using `spawn()`

vvuk
authored and
angelortiz1007
committed
Add inception channel-in-channel multi-process transfer test

vvuk
authored and
angelortiz1007
committed
tests: Introduce `which` parameter in `get_channel_name_arg()` helper

antrik
authored and
angelortiz1007
committed
tests: Move `get_channel_name_arg()` helper to `src/test.rs`

antrik
authored and
angelortiz1007
committed
tests: Introduce `cross_process_embedded_senders_spawn()`

antrik
authored and
angelortiz1007
committed
tests: cleanup: Streamline structure of `_server()` helpers

antrik
authored and
angelortiz1007
committed
tests: cleanup: Introduce a common `spawn_server()` helper function

antrik
authored and
angelortiz1007
committed
tests: cleanup: Avoid need for separate `_server()` pseudo-tests

antrik
authored and
angelortiz1007
committed
Implement ipc-channel on Windows

vvuk
authored and
angelortiz1007
committed
appveyor.yml: Restore testing `inprocess` back-end, not only native one

antrik
authored and
angelortiz1007
committed
tests: Split out SHM object equality check

antrik
authored and
angelortiz1007
committed
windows: fix warning: `reader` doesn't need to be mutable

antrik
authored and
angelortiz1007
committed
windows: cleanup: Change suitable plain comments into doc comments

antrik
authored and
angelortiz1007
committed
windows: cleanup: Use more standard indentation for macro

antrik
authored and
angelortiz1007
committed
windows: Move out original handle in `to_receiver()` and `to_sender()`

antrik
authored and
angelortiz1007
committed
windows: Drop unnecessary `&mut self` in a few places

antrik
authored and
angelortiz1007
committed
windows: cleanup: Switch methods for a more logical order

antrik
authored and
angelortiz1007
committed
windows: Mark `notify_completion()` as unsafe

antrik
authored and
angelortiz1007
committed
windows: Widen too narrow `unsafe` block

antrik
authored and
angelortiz1007
committed
windows: Drop custom `GetMessageResult` type

antrik
authored and
angelortiz1007
committed
windows: More defensive receive buffer handling

antrik
authored and
angelortiz1007
committed
[RemoveMe] Temporarily disable most CI targets

antrik
authored and
angelortiz1007
committed
windows: Add explanation why the `ov` structure needs to be boxed

antrik
authored and
angelortiz1007
committed
windows: Implement `Drop` for `MessageReader`

antrik
authored and
angelortiz1007
committed
windows: Consume reader immediately when moving out handle

antrik
authored and
angelortiz1007
committed
windows: Take ownership of handle in `move_handle_to_process()`

antrik
authored and
angelortiz1007
committed
windows: Assert valid state before consuming receiver

antrik
authored and
angelortiz1007
committed
windows: Don't duplicate handle when consuming receiver

antrik
authored and
angelortiz1007
committed
windows: Remove bogus explicit `impl Send` for `OsIpcSender`

antrik
authored and
angelortiz1007
committed
windows: Add a comment explaining the `impl Send` on `OsIpcReceiver`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Use enum rather than anonymous bool for blocking mode parameter

antrik
authored and
angelortiz1007
committed
windows: Improve placement of comments in `receive_message()`

antrik
authored and
angelortiz1007
committed
windows: Add checks and warnings regarding dangers of `ov` and `read_buf`

antrik
authored and
angelortiz1007
committed
windows: Shrink unnecessarily wide `unsafe` block

antrik
authored and
angelortiz1007
committed
windows: Minor comment fix

antrik
authored and
angelortiz1007
committed
windows: cleanup: More straightforward use of default match case

antrik
authored and
angelortiz1007
committed
windows: Take `WinHandle` rather than `HANDLE` in `write_msg()` and `write_buf()`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Use helper variable consistently

antrik
authored and
angelortiz1007
committed
windows: cleanup: Merge `write_msg()` functionality into `write_buf()`

antrik
authored and
angelortiz1007
committed
windows: Shrink an unnecessarily wide `unsafe` block

antrik
authored and
angelortiz1007
committed
windows: Fix overly eager size check

antrik
authored and
angelortiz1007
committed
windows: Fix another overly eager size check

antrik
authored and
angelortiz1007
committed
windows: Revamp send buffer construction to minimise `unsafe`

antrik
authored and
angelortiz1007
committed
windows: Remove trivial `MessageHeader::size()` helper

antrik
authored and
angelortiz1007
committed
windows: Turn `MessageHeader` into normal struct

antrik
authored and
angelortiz1007
committed
windows: Check for errors on SHM unmapping

antrik
authored and
angelortiz1007
committed
windows: Check for errors on file handle closing

antrik
authored and
angelortiz1007
committed
windows: Add check to make sure we don't leak `OsOpaqueIpcChannel`

antrik
authored and
angelortiz1007
committed
windows: Fix SHM mapping for areas larger than 2^32

antrik
authored and
angelortiz1007
committed
windows: Derive `PartialEq` on `WinError`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Don't intersperse method impls with free-standing function

antrik
authored and
angelortiz1007
committed
windows: cleanup: `start_read()`: Use `match` for error handling

antrik
authored and
angelortiz1007
committed
windows: cleanup: `start_read()`: Consistenly use explicit `return`

antrik
authored and
angelortiz1007
committed
windows: cleanup: `start_read()`: Merge handling of identical cases

antrik
authored and
angelortiz1007
committed
windows: cleanup: `start_read()`: Switch cases for more logical order

antrik
authored and
angelortiz1007
committed
windows: cleanup: `start_read()`: Construct a temporary `Result<>`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Drop redundant comment part

antrik
authored and
angelortiz1007
committed
windows: Fix misplaced comment

antrik
authored and
angelortiz1007
committed
windows: Drop bogus `Result<>` from `notify_completion()`

antrik
authored and
angelortiz1007
committed
windows: Drop bogus comment

antrik
authored and
angelortiz1007
committed
windows: Introduce `MessageReader.fetch_async_result()` helper method

antrik
authored and
angelortiz1007
committed
windows: Move `Send` declaration from `OsIpcReceiver` to `MessageReader`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Consume reader in `read_raw_sized()`

antrik
authored and
angelortiz1007
committed
windows: Avoid code duplication in `read_raw_sized()`

antrik
authored and
angelortiz1007
committed
windows: Take `WinHandle` rather than `HANDLE` in `add_to_iocp()`

antrik
authored and
angelortiz1007
committed
windows: Comment on boxing `OVERLAPPED` inside `OsIpcReceiver.accept()`

antrik
authored and
angelortiz1007
committed
windows: cleanup: `OsIpcReceiver.accept()`: Unwrap handle at actual use sites

antrik
authored and
angelortiz1007
committed
windows: Fix a misleading (outdated?) comment

antrik
authored and
angelortiz1007
committed
windows: cleanup: Use `if let` rather than `is_some()` + `unwrap()`

antrik
authored and
angelortiz1007
committed
windows: cleanup: More idiomatic search code

antrik
authored and
angelortiz1007
committed
windows: cleanup: Use `if let` rather than one-arm `match`

antrik
authored and
angelortiz1007
committed
windows: Don't explicitly set `ErrorKind::BrokenPipe` on closed sender

antrik
authored and
angelortiz1007
committed
windows: cleanup: Use `while let` rather than `loop` + `match`

antrik
authored and
angelortiz1007
committed
windows: refactor: More straightforward "closed" status handling

antrik
authored and
angelortiz1007
committed
windows: Don't delay "sender closed" notification from `select()`

antrik
authored and
angelortiz1007
committed
windows: Handle channel closed events directly where possible

antrik
authored and
angelortiz1007
committed
windows: cleanup: Simplify control flow

antrik
authored and
angelortiz1007
committed
windows: Introduce `closed_readers` vector instead of `MessageReader.closed` flag

antrik
authored and
angelortiz1007
committed
windows: cleanup: Rename `WinHandle.take()` to `take_raw()`

antrik
authored and
angelortiz1007
committed
windows: cleanup: More idiomatic `for` loops

antrik
authored and
angelortiz1007
committed
windows: cleanup: More idiomatic use of tuples

antrik
authored and
angelortiz1007
committed
windows: Use `WinHandle` in more places

antrik
authored and
angelortiz1007
committed
windows: refactor: (Re-)introduce `WinHandle.take()` with expected meaning

antrik
authored and
angelortiz1007
committed
windows: Use explicit `as_raw()` on WinHandle instead of `deref()`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Simpler casting for `completion_key`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Tighten scope of `nbytes` local variable

antrik
authored and
angelortiz1007
committed
windows: cleanup: Streamline handling of reader list in `select()`

antrik
authored and
angelortiz1007
committed
windows: Fix `unsafe` coverage in `OsIpcReceiverSet.select()`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Be more explicit about completion key creation

antrik
authored and
angelortiz1007
committed
windows: Rename `set_id` to `entry_id`

antrik
authored and
angelortiz1007
committed
windows: cleanup: More idiomatic handling of `io_err`

antrik
authored and
angelortiz1007
committed
windows: cleanup: Pass status as a proper `Result<>`

antrik
authored and
angelortiz1007
committed
windows: cleanup: `match` on errors in `notify_completion()`

antrik
authored and
angelortiz1007
committed
windows: More defensive `read_in_progress` handling

antrik
authored and
angelortiz1007
committed
windows: Make `MessageReader.ov` optional

antrik
authored and
angelortiz1007
committed
windows: Drop explicit `read_in_progress` flag

antrik
authored and
angelortiz1007
committed
windows: Avoid leaking unsafety outside `unsafe` blocks

antrik
authored and
angelortiz1007
committed
windows: Clarify comment about `start_read()` for receivers in sets

antrik
authored and
angelortiz1007
committed
windows: Put `ov` and `buf` in the same `AliasedCell<>`

antrik
authored and
angelortiz1007
committed
windows: Don't ignore `CancelIoEx()` errors

antrik
authored and
angelortiz1007
committed
windows: Don't panic on unknown errors in `notify_completion()`

antrik
authored and
angelortiz1007
committed
windows: refactor: Split out `OsIpcReceiverSet.fetch_iocp_result()`

antrik
authored and
angelortiz1007
committed
windows: Make `cancel_io()` sound

antrik
authored and
angelortiz1007
committed
[RemoveMe] Temporarily restore all CI targets using `unix` back-end

antrik
authored and
angelortiz1007
committed
WIP: threaded fragment tests

antrik
authored and
angelortiz1007
committed
windows: Properly hide all `win32-trace` code behind conditionals

antrik
authored and
angelortiz1007
committed
windows: Introduce `MessageReader.get_raw_handle()` debug helper

antrik
authored and
angelortiz1007
committed
windows: Move `handle` into `AsyncData` as well

antrik
authored and
angelortiz1007
committed
fixup! Implement ipc-channel on Windows
angelortiz1007
committed
Update for Rust 2018.
angelortiz1007
committed

Commits on Jun 26, 2019

Migrated ipc-channel to use winapi version 3. Removed kernel3
angelortiz1007
committed

Commits on Jul 3, 2019

Test of GetNamedPipeClientSessionId() and GetNamedPipeClientSessionId() apis to verify if self.h and other.h handles point to the same object.
angelortiz1007
committed