Don't use SSE4.1 instructions unless the target supports it #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes servo#48. Enabling the SIMD code path now requires building with `RUSTFLAGS="-C target-feature=+sse4.1"` or similar.
|
Can we not use features somehow for this? Using RUSTFLAGS is not something we're supposed to be doing is what I understood from the Cargo team. |
|
We can, we need to add a build script that checks for features and adds to |
|
☔ The latest upstream changes (presumably #141) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Is there no way for rustc to be hinted to use SSE4.1 by itself if it can, with the naive code? |
bors-servo
pushed a commit
that referenced
this pull request
Jan 17, 2018
Don't use SSE4.1 instructions unless the target supports it This is a rebase of #140. Fixes #140, fixes #48. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/euclid/263) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48. r? @pcwalton
Enabling the SIMD code path now requires building with
RUSTFLAGS="-C target-feature=+sse4.1"or similar.This change is