Skip to content

[breaking][core-graphics] Allow dropping event from CGEventTap callback - #724

Merged
jdm merged 1 commit into
servo:mainfrom
tmandry:cgeventtap-drop
May 26, 2025
Merged

jdm merged 1 commit into
servo:mainfrom
tmandry:cgeventtap-drop

Conversation

@tmandry

@tmandry tmandry commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

This allows CGEventTap callbacks to capture (drop) an event entirely. This is useful for implementing system-wide hotkeys, among other things.

This PR is essentially a rebase of #492. While releasing the breaking change in #710 we might as well include this, since users of CGEventTap will need to update their code anyway.

Closes #492, #664, #665.

@tmandry

tmandry commented Mar 16, 2025

Copy link
Copy Markdown
Contributor Author

cc @wusyong since you reviewed #710.

@merlinaudio

Copy link
Copy Markdown

I need this, anything I can do to help? What's required to get this merged?

Thanks for the great work :)

@jdm
jdm force-pushed the cgeventtap-drop branch from 31a1edf to 148a1d2 Compare May 26, 2025 18:40
@jdm
jdm enabled auto-merge May 26, 2025 18:47
@jdm
jdm added this pull request to the merge queue May 26, 2025
Merged via the queue into servo:main with commit 7e4d907 May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants