Skip to content

Optimize PersistRequest #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 6, 2025
Merged

Optimize PersistRequest #353

merged 2 commits into from
Feb 6, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

@SergeiPavlov SergeiPavlov commented Feb 6, 2025 •
edited
Loading

Split it into two immutable types:

  • record struct PreparedPersistRequest
  • readonly struct PersistRequest

Because of two stages of request preparation.

There were ~40K retained instances.
This optimization will save >1MB

Also:

  • Make PersistRequestBuilderTask immutable
  • Make PersistRequestKind sbyte enum to reduce size of PersistRequestBuilderTask.

@SergeiPavlov SergeiPavlov merged commit 62bbba5 into master-servicetitan Feb 6, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the PersistRequest branch February 6, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@botinko botinko botinko approved these changes

@snaumenko-st snaumenko-st Awaiting requested review from snaumenko-st

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergeiPavlov @botinko