Skip to content

Upgrade SqlClient #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Upgrade SqlClient #346

merged 3 commits into from
Jan 28, 2025

Conversation

SergeiPavlov
Copy link
Collaborator

No description provided.

@botinko
Copy link

botinko commented Jan 26, 2025

They published it just 2 days ago, what is the urgency to update?

@SergeiPavlov
Copy link
Collaborator Author

They published it just 2 days ago, what is the urgency to update?

There is no urgency.
The earlier we start testing, the better.

This DO version is planed to be in Release >2 months

@botinko
Copy link

botinko commented Jan 28, 2025

@SergeiPavlov If we want to start testing, we can update it in ST-Mono. No reason to force a new version by DO itself....
That is my understanding, maybe there is another reasons to update in DO.

@SergeiPavlov
Copy link
Collaborator Author

SergeiPavlov commented Jan 28, 2025

That is my understanding, maybe there is another reasons to update in DO.

  1. To run DO tests with the new SqlClient

  2. My reasoning is the opposite:
    We update Nugets by default unless there is a known reason not to.

@SergeiPavlov SergeiPavlov merged commit 2816e94 into master-servicetitan Jan 28, 2025
4 checks passed
@SergeiPavlov SergeiPavlov deleted the upgradeSqlClient branch January 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants