Optimize EntitySetState
#241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botinko
reviewed
Aug 21, 2024
| { | ||
| IsLoaded = state.IsLoaded; | ||
| TotalItemCount = state.TotalItemCount; | ||
| AddedKeys = state.addedKeys.Values.ToList(); |
There was a problem hiding this comment.
Minor, but previosly, BackupedState was responsible to create a copy of AddedKeys , RemovedKeys. But now it's up to caller. API/Behavior is not consistent, as you can pass everything, that can be changed.
There was a problem hiding this comment.
This is not an API, it is private class used in single place.
botinko
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashSet<Key>instead ofDictionary<Key, Key>BackedUpStatetorecord structfor localityKeyMappingtoreadonly struct