-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow --ssh-opts starts with hyphen #277
Conversation
Hmm, I'm a bit confused since I don't have this issue when using |
Also, I don't think
|
sorry, It's my typo |
Oh, right |
It'd also be nice to add a regression test for this. Something like
will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the contribution!
for example
deploy .#s --hostname example.com --ssh-opts '-p 1145'
without
allow_hyphen_values
:workaround: add a space after quote
deploy .#s --hostname example.com --ssh-opts ' -p 1145'
but it might be better adding
allow_hyphen_values = true