-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace current CI implementation with Nix-flake based CI #97
base: main
Are you sure you want to change the base?
Conversation
(might take some messing around with, this is my first time setting something up with mkPipeline) |
that seems to all be working except for weeder, which fails with
I might leave figuring that out to somebody that knows more about cabal |
Setting as draft until serokell/serokell.nix#69 is addressed, then will need to clean up commits |
I noticed that we're missing a few steps we used to have (there may be more):
Also:
Questions:
|
I'll add in the missing test-runnig and try to add all the missing tests too
With using mkPipeline, it's generating our pipeline steps from what is under |
Adding xrefcheck would be ugly unless we can first deal with serokell/xrefcheck#54 (which would probably ending up looking exactly like this PR) |
It also seems like "validate cabal files" might be tedious to add, I tried it and it failed while attempting network access, is this because I configured it wrong? or is that step just impure |
Looks like it's impure. The script |
…ipelineFile without system
…specify `validatesWithoutBuild` to avoid flake validation running without builds in updated mkPipeline
2f94b32
to
ac3bc48
Compare
71a1b4d
to
bd692fa
Compare
bd692fa
to
f5e7977
Compare
9b130c0
to
b67a0af
Compare
Description
We have newer practices for CI systems, so we should probably utilize them here, including our newest addition:
mkPipeline
, which generates individual pipeline steps for CI out of your flake, as opposed to lumping them all into anix flake check
step.Related issue(s)
#26
✅ Checklist for your Pull Request
Related changes (conditional)
Tests
silently reappearing again.
Documentation
Stylistic guide (mandatory)