New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

video path is enabled in stream #1415

Merged

serengil merged 6 commits into serengil:master from Mehrab-Shahbazi:master

Jan 6, 2025

+110 −76

Contributor

Mehrab-Shahbazi commented Jan 1, 2025

Tickets

https://github.com/serengil/deepface/issues/XXX

What has been done

this simple PR enable the stream function runs on a video path as well as webcam.

How to test

make lint && make test


          video path is enabled in stream

33a502f

Contributor Author

Mehrab-Shahbazi commented Jan 1, 2025

i will be happy if u accept it


          saving video output in stream is enabled

2f9ef19

Contributor Author

Mehrab-Shahbazi commented Jan 1, 2025

i add a new commit that taking output video path is optional and can save the output

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/DeepFace.py Outdated Show resolved Hide resolved

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Outdated Show resolved Hide resolved

Mehrab-Shahbazi added 2 commits

January 2, 2025 21:51


          solved pr comments: restore comments and used one line if

c513b26


          remove #type ignore comments

aa47e33

Contributor Author

Mehrab-Shahbazi commented Jan 2, 2025

i restored the comments and also changed that "if" to single line if.

Owner

serengil commented Jan 3, 2025

Linting job failed - https://github.com/serengil/deepface/actions/runs/12586949624/job/35107769180?pr=1415

serengil reviewed

View reviewed changes

deepface/modules/streaming.py Show resolved Hide resolved


          ensure output path

5af32fa

Contributor Author

Mehrab-Shahbazi commented Jan 3, 2025

need changes for linting? or its okay.

Owner

serengil commented Jan 3, 2025

need changes for linting? or its okay.

it must be fixed, otherwise pipeline fails

Contributor Author

Mehrab-Shahbazi commented Jan 3, 2025

need changes for linting? or its okay.

it must be fixed, otherwise pipeline fails

you didn't run the test?


          write small dockstring for lint

15a4f46

Contributor Author

Mehrab-Shahbazi commented Jan 4, 2025

I think it was for having too long lines in dockstring. i modify it. I hope this time works fine.
Thanks

serengil merged commit c465234 into serengil:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet