add partialeq to RawValue #1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Thanks for the PR!
I think I would prefer not to add the impl. People are going to find it unexpected that the equal JSON values [ null ] and [null] would be considered unequal by RawValue.
The underlying JSON bytes are publicly exposed though, so any downstream code can use raw_a.get() == raw_b.get() without this impl when this is the behavior they want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RawValue does not currently implement
PartialEq, which is a blocker for:gltf-rs/gltf#442
This pr fixes implements
PartialEqforRawValueto fix that.