Skip to content

fix(scripts): use node-compatible entrypoint guards - #15

Merged
astykyj merged 1 commit into
mainfrom
fix/node-compatible-script-entrypoints
Apr 29, 2026
Merged

fix(scripts): use node-compatible entrypoint guards#15
astykyj merged 1 commit into
mainfrom
fix/node-compatible-script-entrypoints

Conversation

@astykyj

@astykyj astykyj commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace import.meta.main guards in Node-invoked .mjs scripts with a process.argv[1] entrypoint check.
  • Add a scripts smoke test to prevent reintroducing import.meta.main in these Node-run scripts.

Verification

  • bun test tests/scripts-smoke.test.ts
  • bun run typecheck

@astykyj
astykyj enabled auto-merge (squash) April 29, 2026 03:15
heath-s
heath-s approved these changes Apr 29, 2026
View reviewed changes

@heath-s heath-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@astykyj
astykyj merged commit 4075cd5 into main Apr 29, 2026
3 checks passed
@astykyj
astykyj deleted the fix/node-compatible-script-entrypoints branch April 29, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heath-s heath-s heath-s approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@astykyj @heath-s @astyfx