Onboarding hub new cards content #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agusruidiazgd
changed the title
semd
reviewed
Oct 8, 2024
...oarding/components/onboarding_body/cards/assistant/components/connectors/connector_cards.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...oarding/components/onboarding_body/cards/assistant/components/connectors/connector_setup.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...oarding/components/onboarding_body/cards/assistant/components/connectors/connector_cards.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...ion/public/onboarding/components/onboarding_body/cards/assistant/assistant_check_complete.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...ion/public/onboarding/components/onboarding_body/cards/assistant/assistant_check_complete.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...omponents/onboarding_body/cards/assistant/components/connectors/create_connector_popover.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...omponents/onboarding_body/cards/assistant/components/connectors/create_connector_popover.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...ty_solution/public/onboarding/components/onboarding_body/cards/common/card_content_panel.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...ty_solution/public/onboarding/components/onboarding_body/cards/common/card_content_panel.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 8, 2024
...ty_solution/public/onboarding/components/onboarding_body/cards/common/card_content_panel.tsx
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 9, 2024
...curity_solution/public/onboarding/components/onboarding_body/cards/assistant/translations.ts
Outdated
Show resolved
Hide resolved
semd
reviewed
Oct 9, 2024
...ion/public/onboarding/components/onboarding_body/cards/assistant/assistant_check_complete.ts
Outdated
Show resolved
Hide resolved
semd
added a commit
to elastic/kibana
that referenced
this pull request
Oct 11, 2024
## Summary Issue: #189487 This PR is the final implementation of the Onboarding page redesign. It has been developed in collaboration with @angorayc and @agusruidiazgd, using this branch as a feature branch. It already includes 2 smaller PRs that have already been reviewed and approved by the @elastic/security-threat-hunting-explore team: - semd#8 - semd#9 ### Changes - Onboarding page architecture refactor ([issue](#174766)) - Fixes #183765 (from [this Meta issue](#183760)) --- - The progress bar has been removed <img width="903" alt="progress bar" src="https://github.com/user-attachments/assets/f16f3b6d-609f-4178-b83e-3b2106ba56ea"> --- - Card styles updated: - Icons updated to custom SVGs to have the correct color - Icon with circle background - Card internal content border removed | Old | New | | - | - | |<img width="1172" alt="Old styles" src="https://github.com/user-attachments/assets/5a75cd84-a30d-4621-88e3-17d837165016">|<img width="1172" alt="New styles" src="https://github.com/user-attachments/assets/8059bcbc-2f3d-4c7e-ba4f-041a58b51372">| --- - Completed card styles updated: - Icon with green circle background | Old | New | | - | - | |<img width="1172" alt="Old styles complete" src="https://github.com/user-attachments/assets/3258c7be-4ffe-4d25-9cdb-d4fce66ce451">|<img width="1172" alt="New styles complete" src="https://github.com/user-attachments/assets/7dac6ec0-d78d-4881-ae84-3b46562c6d7d">| --- - Improved "Add data with integrations" card | Old | New | | - | - | |<img width="1174" alt="old integrations card" src="https://github.com/user-attachments/assets/3c65c4f5-004b-4619-aa92-26ec0656a8e5">|<img width="1174" alt="new integrations card" src="https://github.com/user-attachments/assets/634e5249-b169-4c93-865e-b82453db90bf">| --- - New "Configure AI assistant" card in a new "Discover Elastic AI" group https://github.com/user-attachments/assets/39bd0dd4-88ba-47df-a77b-6b9b2a185cef --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Agustina Nahir Ruidiaz <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
## Summary Issue: elastic#189487 This PR is the final implementation of the Onboarding page redesign. It has been developed in collaboration with @angorayc and @agusruidiazgd, using this branch as a feature branch. It already includes 2 smaller PRs that have already been reviewed and approved by the @elastic/security-threat-hunting-explore team: - semd#8 - semd#9 ### Changes - Onboarding page architecture refactor ([issue](elastic#174766)) - Fixes elastic#183765 (from [this Meta issue](elastic#183760)) --- - The progress bar has been removed <img width="903" alt="progress bar" src="https://github.com/user-attachments/assets/f16f3b6d-609f-4178-b83e-3b2106ba56ea"> --- - Card styles updated: - Icons updated to custom SVGs to have the correct color - Icon with circle background - Card internal content border removed | Old | New | | - | - | |<img width="1172" alt="Old styles" src="https://github.com/user-attachments/assets/5a75cd84-a30d-4621-88e3-17d837165016">|<img width="1172" alt="New styles" src="https://github.com/user-attachments/assets/8059bcbc-2f3d-4c7e-ba4f-041a58b51372">| --- - Completed card styles updated: - Icon with green circle background | Old | New | | - | - | |<img width="1172" alt="Old styles complete" src="https://github.com/user-attachments/assets/3258c7be-4ffe-4d25-9cdb-d4fce66ce451">|<img width="1172" alt="New styles complete" src="https://github.com/user-attachments/assets/7dac6ec0-d78d-4881-ae84-3b46562c6d7d">| --- - Improved "Add data with integrations" card | Old | New | | - | - | |<img width="1174" alt="old integrations card" src="https://github.com/user-attachments/assets/3c65c4f5-004b-4619-aa92-26ec0656a8e5">|<img width="1174" alt="new integrations card" src="https://github.com/user-attachments/assets/634e5249-b169-4c93-865e-b82453db90bf">| --- - New "Configure AI assistant" card in a new "Discover Elastic AI" group https://github.com/user-attachments/assets/39bd0dd4-88ba-47df-a77b-6b9b2a185cef --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Angela Chuang <[email protected]> Co-authored-by: Agustina Nahir Ruidiaz <[email protected]> (cherry picked from commit d39c75a)
elasticmachine
pushed a commit
that referenced
this pull request
Jan 16, 2025
## Summary Extracted from elastic#206411 [[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267344#019469ff-7fb9-4c5d-8569-2e445aab27be) [[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267344/jobs/019469ff-7fb9-4c5d-8569-2e445aab27be/artifacts/01946a1c-62fa-4d30-8863-1b40f8c0b924) Jest Tests #9 / Overview renders correctly when there is no user data view This simplifies overview.tsx by refactoring to rtl and removing the whole snapshot. The snapshot was not useful and the test is still making sure that the intended component is still rendered. By removing enzyme, the test now works properly for both react 17 and 18.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remaining cards added to the new onboarding hub page.
Criteria to complete each of the cards:
Dashboards → visit dashboard page
Rules → have at least one rule installed and enabled
Alerts → visit alerts page
AI assistant → have at least one connector created
Attack discovery → visit attack discovery page
Screen.Recording.2024-10-08.at.16.56.44.mov
Checklist
Delete any items that are not applicable to this PR.