Update npm-publish workflow to include --provenance flag for package …#1776
Update npm-publish workflow to include --provenance flag for package …#1776jcortejoso wants to merge 1 commit intodevfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workflow file Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/npm-publish.yml:
- Line 425: The publish command line "npx npm@latest publish package.tgz
--access restricted --provenance --tag alpha $DRY_RUN" is invalid because
--provenance cannot be used with --access restricted; either remove --provenance
from that publish invocation (Option A) so the command becomes a restricted
publish, or change --access restricted to --access public (Option B) so
provenance can be generated; also ensure the package name
(`@selfxyz/mobile-sdk-alpha`) and CI secrets/policy allow public publishing before
choosing Option B.
431a1cf to
1dced7c
Compare
Description
Update npm-publish workflow to include --provenance flag for package publishing: https://docs.npmjs.com/generating-provenance-statements
Summary by CodeRabbit