feat: add vertical input for Stackbit 1248

[bitcoisas]

What is this PR for?

This PR adds vertical layout support for Stackbit 1248 seed input, covering the input/loading side of #834.

A "Vertical" option is added to the "Load from 1248" submenu alongside the existing "Standard" layout. Also, this PR complement this other one: #847 (backup side).

Closes input part of #834

Changes made to:

• Code
• Tests
• Docs
• CHANGELOG

Did you build the code and tested on device?

What is the purpose of this pull request?

• Bug fix
• New feature
• Docs update
• Other

Screenshots:

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.35%. Comparing base (9ef5803) to head (5bb237a).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #862      +/-   ##
===========================================
+ Coverage    97.30%   97.35%   +0.05%     
===========================================
  Files           83       83              
  Lines        10798    10973     +175     
===========================================
+ Hits         10507    10683     +176     
+ Misses         291      290       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bitcoisas]

Should these changes be added to the changelog? If so, for the May release?

[qlrd]

Should these changes be added to the changelog? If so, for the May release?

For now make it drat and make changes on CHANGELOG.md

[odudex]

As the form factor allows, try to increase grid size and better use screen surface, making it easier to type.

[qlrd]

some nits to DRY:

[bitcoisas]

@qlrd Implemented the DRY refactor suggestion and removed the layout size limiter for larger devices @odudex, now making full use of the available screen. Updated docs and screenshots accordingly.

Still need to test on device, i will update here later today! :)

[bitcoisas]

Still need to test on device, i will update here later today! :)

Done, updated the PR Device image tho!

[qlrd]

LGTM, but if possible, i would check the uncovered lines. Saw them and found weird that they aren't covered. Either untested by some case or those pieces receive more love.

[joaozinhom]

LGTM, there are some uncovered lines to review but i think its a simple mock test work, in my view the uncovered lines are in the following functions:
_toggle_bit_vertical;
_index_vertical;

[qlrd]

LGTM, there are some uncovered lines to review but i think its a simple mock test work, in my view the uncovered lines are in the following functions: _toggle_bit_vertical; _index_vertical;

One thing that i learned here is that we have potential dead codes, @bitcoisas check if they're dead codes or just need mock like @joaozinhom says

[bitcoisas]

_toggle_bit_vertical;
_index_vertical;

i will work on the coverage later today, checking if we have dead code and also writing some new unit tests too! Thanks again team learning a lot with your guidance! :)

[bitcoisas]

LGTM, there are some uncovered lines to review but i think its a simple mock test work, in my view the uncovered lines are in the following functions: _toggle_bit_vertical; _index_vertical;

One thing that i learned here is that we have potential dead codes, @bitcoisas check if they're dead codes or just need mock like @joaozinhom says

Good catch @qlrd and @joaozinhom ! The if digits[col] == 0 branch in both clamps is unreachable since those cases are already blocked by VERT_INVALID_CELLS, so I simplified both to new_val = 0.

Added unit tests for the remaining paths: early return for invalid cells and forward navigation in _index_vertical.

Now we have the 100% coverage and a cleaner code. Thank you again for the reviews.

[joaozinhom]

ACK 22e2533

[qlrd]

Two last commits could go as one

[bitcoisas]

Two last commits could go as one

Done, squashed into one!

[qlrd]

Some nits and a doubt

[qlrd]

Dont get why change this

[bitcoisas]

This extra button is required because our PR added a Standard/Vertical orientation selector before entering the 1248 grid

[bitcoisas]

Just a FUP, i'm working on the updates that you suggested/asked to change here @qlrd. And thank you very much to make me level up every day! :)