feat: add Stackbit 1248 vertical input#858
Closed
bitcoisas wants to merge 5 commits into
Closed
Conversation
Add grouped and compact export methods.
Test grouped/compact layouts + 24-word pagination.
bitcoisas
force-pushed
the
feat/stackbit-1248-vertical-input
branch
2 times, most recently
from
ef3909c to
8f9d11c
Compare
bitcoisas
force-pushed
the
feat/stackbit-1248-vertical-input
branch
from
8f9d11c to
89112a2
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #858 +/- ##
===========================================
- Coverage 97.31% 97.22% -0.09%
===========================================
Files 83 83
Lines 10573 10991 +418
===========================================
+ Hits 10289 10686 +397
- Misses 284 305 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR adds vertical layout support for Stackbit 1248 seed input, covering the input/loading side of #834.
A "Vertical" option is added to the "Load from 1248" submenu alongside the existing "Standard" layout. Also, this PR complement this other one: #847 (backup side).
Closes input part of #834
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?
Screenshots: