Small change on Touch Threshold, Buttons Debounce and Swipe Threshold#793
Conversation
|
First PR from #771 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #793 +/- ##
========================================
Coverage 97.38% 97.38%
========================================
Files 83 83
Lines 10543 10544 +1
========================================
+ Hits 10267 10268 +1
Misses 276 276 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| namespace = "settings.touchscreen" | ||
| default_th = 40 if kboard.is_wonder_k else 22 | ||
| threshold = NumberSetting(int, "threshold", default_th, [10, 200]) | ||
| threshold = NumberSetting(int, "threshold", default_th, [2, 200]) |
There was a problem hiding this comment.
Any real situation where sensitivity had to be set so aggressively (value=2) ?
There was a problem hiding this comment.
I can't test against all possible device lots, so I'd rather leave this flexible. In some cases, like when the user is wearing gloves, higher sensitivity can be helpful
There was a problem hiding this comment.
If it didn't brick any device (like being always pressed), it's fine.
There was a problem hiding this comment.
If the user changes this value, the device immediately applies it before exiting the settings menu, so they will notice right away and can simply reset the device to revert to the previous value. I tested with a setting of 2 and didn't manage to brick any of my touch devices (couldn't test on the Amigo due to its existing touch issues): TZT, Yahboom, WonderMV, Embed Fire, WonderK Pro.
On the WonderK Pro, a little below 10 already feels good, and the Embed Fire was performing so well that it was already set to 2. Other devices had poorer results, but that's exactly why the setting exists: anyone can adjust it according to the behavior of their specific device, rather than us enforcing or constraining the value.
|
Thank you! |
2 participants
What is this PR for?
Settings / Constants
Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?