Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: db_name should be without double quotation and no '#' comment af… #465

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix: db_name should be without double quotation and no '#' comment af… #465

merged 1 commit into from
Feb 24, 2025

Conversation

wangwq10
Copy link
Contributor

db_type is mysql:

  1. if db_name ="ccr" , it will create database which name is "ccr" (with double quotation) which failed
  2. if db_name =ccr #xxxx, it will create database which name is ccr #xxxx which failed

@wangwq10
fix: db_name should be without double quotation and no '#' comment af…
d82a22f 
…ter, otherwise start_syncer.sh will failed when db_type is mysql.
@w41ter w41ter merged commit ba24062 into selectdb:dev Feb 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w41ter w41ter w41ter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangwq10 @w41ter