Skip to content

Conversation

@sigaloid
Copy link

No description provided.

@seladb
Copy link
Owner

seladb commented Jan 9, 2022

Thanks for your contribution @sigaloid ! Can you please fix the clippy errors before we merge your PR?

Also - it'd be great if you can add a test.

@sigaloid
Copy link
Author

Hi, I think I've fixed the clippy error. Also, I'm unfamiliar with the test structure so a test that I write would likely not help very much or be poorly written 😔

@seladb
Copy link
Owner

seladb commented Apr 17, 2022

@sigaloid I'm sorry for the late response. I think you can add a simple test here:
https://github.com/seladb/pickledb-rs/blob/master/tests/pickledb_key_value_tests.rs

Also - the clippy errors were fixed here: #25 so you can update your branch and it should work now

@sigaloid sigaloid changed the title Add new_or_load function that loads a DB if available, and if not, create DB Add load_or_new function that loads a DB if available, and if not, create DB May 30, 2022
@sigaloid
Copy link
Author

Successfully added tests, looks like it's passing in my repo but needs a maintainer to run here.

@seladb
Copy link
Owner

seladb commented Jan 23, 2023

@sigaloid please see a few clippy and fmt issues

@alexthe2
Copy link

alexthe2 commented May 7, 2024

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants