This repository was archived by the owner on Dec 19, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 75
fix: #142 raw literal with backslashes becomes "unescaped" #143
Open
dim0xff
wants to merge
3
commits into
segmentio:master
Choose a base branch
from
dim0xff:bug/raw-literal-backslash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add failing test
ccoVeille
reviewed
Aug 11, 2024
ccoVeille
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no tests updated, wasn't any?
Author
@ccoVeille I added test to _fixtures/struct_tags.go and test expectation to _fixtures/struct_tags__exp.go Fixtures are being tested via |
|
Oh that's right. I expected the tests to be in a _test.go file |
ccoVeille
approved these changes
Aug 12, 2024
|
Hi there, |
|
This is also a problem for us that I just discovered today. If this could be merged, that would be amazing @mckern |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #142