Conversation
|
| Buildkite.md.terminal(coverage), | ||
| ].join('\n\n'); | ||
|
|
||
| await Buildkite.annotate(buildkiteOutput, { |
There was a problem hiding this comment.
@samchungy how do you feel about having this reporter support both Buildkite and GitHub 😬
If we want coverage integrations across both, it may be wasteful to define two reporters and to run renderCoverageText twice.
There was a problem hiding this comment.
I don't love it but renderCoverageText is kinda costly I guess. Even the loop processing this I guess.
Do reporters run in series? I wonder if we could store it in memory? 🤔
If we do this -> might want to rename the reporter? maybe reporters/annotate/index.ts?
This is just the first step of dumping a coverage table out to a Buildkite annotation and GitHub check run. We can later build towards: