Open
Conversation
🦋 Changeset detectedLatest commit: 08f178c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zbrydon
approved these changes
Apr 1, 2026
| const identifiers = root.findAll({ | ||
| rule: { | ||
| kind: 'identifier', | ||
| regex: `^${functionName}$`, |
Contributor
There was a problem hiding this comment.
Can/should we be bothered to escape this just in case people have some funky function names?
Contributor
Author
There was a problem hiding this comment.
Nah it should be okay, we aren't automatically running this via lint or anything so nothing malicious should result of it
Contributor
There was a problem hiding this comment.
Should we call out that this won't detect re exporting things eg. something weird like this
// impl.ts
export const doThing = () => 'x';
export const caller = () => doThing();// index.ts
export { doThing as default } from './impl';// spy.ts
import * as index from './index.ts';
jest.spyOn(index, 'default');
Contributor
Author
There was a problem hiding this comment.
I reckon that's a skill issue if so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vibe coded a little something something for detecting invalid spy usage when migrating from Jest -> Vitest. This was a little difficult to throw into a lint rule and I figure it'll mostly be for 1 time runs to get from Jest -> Vitest.