vanilla-extract: Ensure Vanilla Extract styles are bundled into isolated modules#244
Merged
vanilla-extract: Ensure Vanilla Extract styles are bundled into isolated modules#244
Conversation
🦋 Changeset detectedLatest commit: 9e1a683 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
askoufis
commented
Nov 14, 2025
Contributor
Author
There was a problem hiding this comment.
The changes in this file were meant to be added in #242. They don't need to be published however since they made it into the published package anyway.
Contributor
There was a problem hiding this comment.
Ah interesting. Works in the pipeline but out of sync with the source. Possibly something we try to catch via linting.
askoufis
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one thing we forgot to consider when moving to tsdown in #239 was handling Vanilla Extract styles. Since v2.0.2, Vanilla Extract code in
@capsizecss/vanilla-extracthas been bundled alongside its API code in a singleindex.mjs/cjsfile. This results in aStyles were unable to be assigned to a fileerror when importing the package because Vanilla Extract usage is no longer isolated to a.css.mjs/cjsfile (as it was in v2.0.1).Crackle handled this with a complicated manual chunking configuration that would "pre-compile" Vanilla Extract modules and keep them isolated from non Vanilla Extract code. The pre-compilation is an optimization of dubious utility, and in the case of this tiny library a correct bundle output can be recreated with
unbundle: true(effectively the same aspreserveModules: true).