Make Networks Customizables #295
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still errors in the testing |
amdfxlucas
force-pushed
the
seed-contrib13
branch
from
f24e4f1 to
30da009
Compare
|
i don't like the code duplication between NodeScope and NetScope. I'll think of a more elegant solution .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Networks have a bunch of configuration parameters: MTU, latency, bandwidth, drop.
However these are not modeled as Options yet.
Thus you have to configure everything manually by calling the respective setters on all Networks we want to have values other than the default.
Instead there should be NetMTU, NetLatency etc. options which can be 'set' on Networks.
Moreover Networks are always owned by ASes, which are also Customizables and can possess (AS-specific) overrides for NetOptions and inherit these to their children (Network-Customizables ).
In this design the NetMTU could be easily changed globally for all Nets in the simulation, by a single line on the BaseLayer , rather than having to iterate over all ASes and their Nets. (i.e. global Jumbo Frame Use MTU==9000)
Also it would allow to change the values of options without having to rebuild and compile any docker images (OptionMode.RUN_TIME) But currently in this PR they're BUILD_TIME only for now (as it used to be).
Also it would be nice if we could specify the global default values for NetOptions ( i.e. for MTU ) per NetworkType (higher values for IX and XC maybe and 1500 for LocalNets ). But this is not possible yet.