Permanent x/batching pruning solution #673
Draft
+2,014
−484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacheigriega
force-pushed
the
hy/data-result-prune
branch
from
00e8376 to
03acea4
Compare
Prune batches and their associated data at every block based on two new module parameters NumBatchesToKeep and MaxBatchPrunePerBlock. For pruning data results and their batch assignment data, we resort to naive implementation because there is no mapping to data result objects from batch number or data result ID. In this implementation we go through `MaxDataResultsToCheckForPrune` items in the store starting from a random point and delete those whose associated batches have been pruned.
hacheigriega
force-pushed
the
hy/data-result-prune
branch
from
03acea4 to
87b427e
Compare
hacheigriega
force-pushed
the
hy/future-prune
branch
from
38e5257 to
5c7e01c
Compare
hacheigriega
force-pushed
the
hy/data-result-prune
branch
from
87b427e to
02918d8
Compare
We add a new map from batch number to its data results to x/batching state in order to support simple pruning. In simple pruning we remove a batch and all its associated data if necessary to keep the number of batches at the module parameter NumBatchesToKeep.
hacheigriega
force-pushed
the
hy/future-prune
branch
from
5c7e01c to
8f7999c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
We add a new map from batch number to its data results to x/batching state in order to support simple pruning. In simple pruning we remove a batch and all its associated data if necessary to keep the number of batches at the module parameter NumBatchesToKeep.
Related PRs and Issues
Closes #671