Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Nov 26, 2025

  • add CMS signing / check
  • refactor (a lot) scapy/layers/tls/cert.py add add documentation
    • Chain wasn't as useful as it could be. We now have a CertTree class that serves as a certificate store (think like Windows), and properly links certificates against their issuer, to a list of root CAs
    • getchain() allows to find a chain of certificates towards one
    • verify() says if a certificate can be verified against the store
  • support PKINIT in Kerberos
  • fix Kerberos handling in DCE/RPC passive sniffing
  • improve Kerberos handling of the "DELEGATION"-related structures
  • Improve DCE/RPC context handling (keeps the context IDs when re-binding to the same interface, etc.)
  • Add support for Kerberos secure channels in MS-NRPC
  • Add the ability to chose between WindowsNT, Windows2000 and Windows2003+ variants of NTLM when building packets
  • add an ability to NOT send channel bindings in HTTP

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 19.39502% with 453 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.17%. Comparing base (e73137e) to head (144df4e).

Files with missing lines Patch % Lines
scapy/layers/tls/cert.py 20.27% 173 Missing ⚠️
scapy/layers/kerberos.py 14.89% 120 Missing ⚠️
scapy/layers/msrpce/rpcclient.py 12.50% 42 Missing ⚠️
scapy/layers/msrpce/msnrpc.py 0.00% 41 Missing ⚠️
scapy/layers/ntlm.py 42.50% 23 Missing ⚠️
scapy/layers/spnego.py 5.00% 19 Missing ⚠️
scapy/layers/x509.py 42.85% 16 Missing ⚠️
scapy/libs/rfc3961.py 9.09% 10 Missing ⚠️
scapy/modules/ticketer.py 0.00% 6 Missing ⚠️
scapy/layers/http.py 0.00% 2 Missing ⚠️
... and 1 more

❗ There is a different number of reports uploaded between BASE (e73137e) and HEAD (144df4e). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (e73137e) HEAD (144df4e)
12 2
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4879       +/-   ##
===========================================
- Coverage   80.86%   48.17%   -32.70%     
===========================================
  Files         368      350       -18     
  Lines       90271    90234       -37     
===========================================
- Hits        72996    43467    -29529     
- Misses      17275    46767    +29492     
Files with missing lines Coverage Δ
scapy/asn1/mib.py 46.45% <100.00%> (-45.17%) ⬇️
scapy/layers/smb.py 52.15% <ø> (-24.91%) ⬇️
scapy/layers/smbclient.py 22.15% <ø> (-50.90%) ⬇️
scapy/layers/dcerpc.py 45.56% <85.71%> (-44.50%) ⬇️
scapy/layers/http.py 24.03% <0.00%> (-59.62%) ⬇️
scapy/modules/ticketer.py 0.00% <0.00%> (-41.16%) ⬇️
scapy/libs/rfc3961.py 40.64% <9.09%> (-45.23%) ⬇️
scapy/layers/x509.py 87.72% <42.85%> (-9.84%) ⬇️
scapy/layers/spnego.py 28.14% <5.00%> (-42.66%) ⬇️
scapy/layers/ntlm.py 25.66% <42.50%> (-56.25%) ⬇️
... and 4 more

... and 307 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 force-pushed the begin-pkinit branch 2 times, most recently from e7169e7 to c583fe1 Compare November 26, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant