example converter from json to ast #207
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sebastienros @lahma |
lahma
reviewed
Nov 16, 2021
Collaborator
lahma
left a comment
lahma
left a comment
There was a problem hiding this comment.
I think the general idea is sound. Supporting new .NET feels like a good choice, of course until someone complaints about not having this on their Windows XP or something.
| <BuildNumber Condition="'$(BuildNumber)' == ''">0</BuildNumber> | ||
| <Authors>Sebastien Ros</Authors> | ||
| <TargetFrameworks>net461;netstandard2.0</TargetFrameworks> | ||
| <TargetFrameworks>net461;netstandard2.0;net5.0</TargetFrameworks> |
|
|
||
| namespace Esprima.Utils | ||
| { | ||
| public class AstJsonConverter : JsonConverter<object> |
Collaborator
There was a problem hiding this comment.
should we keep this sealed until someone asks for it to be opened, generally I guess we should be able to reproduce the original JSON AST for this to be "feature-complete".
|
|
||
| var op = new JsonSerializerOptions(); | ||
| op.Converters.Add(new AstJsonConverter()); | ||
| var ast = JsonSerializer.Deserialize<Node>(json, op); |
Collaborator
There was a problem hiding this comment.
should the result be asserted? some acceptance criteria library probably could help here for text matching / diffing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #157