Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from travis-ci to GitHub actions, add mypy to build #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fuhrysteve
Copy link

@fuhrysteve fuhrysteve commented Mar 1, 2021

Hope you find this PR useful!

This also fixes a few faux-pas items that mypy found

  • duplicate imports (fixed by adding __all__ to a module)
  • impossible-to-use params on a property decorator

Other things:

  • removes unused import deepcopy
  • fixes a weird error I was having with the build on python 2.7 using multiple inheritance in the BaseWord class. I simply mimicked the behavior in the inheriting class, which seemed to be a reasonable compromise
  • drop support for python 3 versions lower than 3.6 (EOL) while continuing to maintain 2.7 compatibility

Please note that the build won't run for this PR until you merge it (something to do with permissions & this being your repository), however if you'd like to see it passing, you can see it here on my fork: fuhrysteve#1

Fixes the following mypy issues:

plyse/query_tree.py:16: error: Too many arguments
plyse/query_tree.py:59: error: Too many arguments
plyse/query_tree.py:114: error: Too many arguments
plyse/__init__.py:6: error: Incompatible import of "Term" (imported name has type "Type[plyse.expressions.terms.Term]", local name has type "Type[plyse.term_parser.Term]")
Fixes DeprecationWarning: Please use assertTrue instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant