Add config listings, listing types, and listing pricing types#66
Merged
bverbeken merged 1 commit intoJun 17, 2026
Merged
Conversation
bverbeken
requested review from
PabloNeirotti,
mortendevold,
mroloux and
sdivelbiss
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new public TypeScript types to support config-driven “listings” in the chart renderer configuration, including listing type definitions and listing-level pricing entries, and wires them into the existing Pricing.prices union so downstream SDKs can consume them.
Changes:
- Added
listings?: ConfigListing[]andlistingTypes?: ListingTypestoChartRendererConfigOptions. - Introduced listing pricing shapes (
SimplePricingForListing,MultiLevelPricingForListing,PricingForListing) and widenedPricing.pricesto accept them. - Updated type-level tests/examples to cover the new config fields and listing pricing entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/index.ts | Adds listings + listingTypes config fields, exports new listing and listing-pricing types, widens Pricing.prices union. |
| src/index.test.ts | Extends compile-time config/pricing fixtures to include the new listing-related config and pricing shapes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sdivelbiss
approved these changes
Jun 16, 2026
mroloux
approved these changes
Jun 16, 2026
bverbeken
force-pushed
the
ben/seats-459-update-seatsio-types-for-seat-listings
branch
from
2b070d2 to
afee88b
Compare
bverbeken
deleted the
ben/seats-459-update-seatsio-types-for-seat-listings
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the public types backing config-driven listings in the chart renderer.
New types:
ConfigListing,ListingType,ListingTypes,SimplePricingForListing,MultiLevelPricingForListing,PricingForListing.The
Pricing.pricesunion is widened to accept listing pricing alongside category and object pricing.