Skip to content

Add holdBestAvailable types and callbacks#61

Merged
bverbeken merged 4 commits into
mainfrom
hold-best-available-types
Mar 25, 2026
Merged

Add holdBestAvailable types and callbacks#61
bverbeken merged 4 commits into
mainfrom
hold-best-available-types

Conversation

@bverbeken

Copy link
Copy Markdown
Member

Summary

  • Add BestAvailableForHoldingConfig and BestAvailableHeldResult types
  • Add onBestAvailableHeld and onBestAvailableHoldFailed callbacks to ChartRendererCallbacks
  • Add holdBestAvailable method to SeatingChart interface

Test plan

  • yarn build passes
  • yarn test passes

🤖 Generated with Claude Code

bverbeken and others added 2 commits March 25, 2026 05:10
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the public TypeScript typings for the embedded seating chart to support “best available” holding via new config/result types, new renderer callbacks, and a new SeatingChart method, and also adds a new accessibility-related property on selectable objects.

Changes:

  • Add BestAvailableForHoldingConfig and BestAvailableHeldResult types plus holdBestAvailable(...) on SeatingChart.
  • Add onBestAvailableHeld and onBestAvailableHoldFailed to ChartRendererCallbacks.
  • Add WheelchairSpaceType and wheelchairSpaceType on AbstractSelectableObject (plus typing coverage in the test file).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/index.ts Extends the public API typings with best-available holding types/callbacks/method and adds wheelchair-space typing on selectable objects.
src/index.test.ts Updates the “full config” typing test to include the new callbacks and references the new wheelchairSpaceType field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.ts Outdated
Comment thread src/index.ts
Comment thread src/index.ts Outdated
Comment thread src/index.ts
Comment thread src/index.ts
bverbeken and others added 2 commits March 25, 2026 13:00
…or ticketTypes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@bverbeken bverbeken merged commit 61a7ecb into main Mar 25, 2026
1 check passed
@bverbeken bverbeken deleted the hold-best-available-types branch March 25, 2026 12:46
bverbeken added a commit that referenced this pull request Mar 27, 2026
bverbeken added a commit that referenced this pull request Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants