Add holdBestAvailable types and callbacks#61
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the public TypeScript typings for the embedded seating chart to support “best available” holding via new config/result types, new renderer callbacks, and a new SeatingChart method, and also adds a new accessibility-related property on selectable objects.
Changes:
- Add
BestAvailableForHoldingConfigandBestAvailableHeldResulttypes plusholdBestAvailable(...)onSeatingChart. - Add
onBestAvailableHeldandonBestAvailableHoldFailedtoChartRendererCallbacks. - Add
WheelchairSpaceTypeandwheelchairSpaceTypeonAbstractSelectableObject(plus typing coverage in the test file).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/index.ts |
Extends the public API typings with best-available holding types/callbacks/method and adds wheelchair-space typing on selectable objects. |
src/index.test.ts |
Updates the “full config” typing test to include the new callbacks and references the new wheelchairSpaceType field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…or ticketTypes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mroloux
approved these changes
Mar 25, 2026
bverbeken
added a commit
that referenced
this pull request
Mar 27, 2026
This reverts commit 61a7ecb.
bverbeken
added a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BestAvailableForHoldingConfigandBestAvailableHeldResulttypesonBestAvailableHeldandonBestAvailableHoldFailedcallbacks toChartRendererCallbacksholdBestAvailablemethod toSeatingChartinterfaceTest plan
yarn buildpassesyarn testpasses🤖 Generated with Claude Code