compile.sh: correct bug of last test not in report #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was noticed that the last test of each category wasn't displayed in the report. The problem was obviously a mistake in a loop that doesn't handle the last test. In fact, the while loop reading test cases uses bash process substitution which is a bad idea. This method split lines on newline character and will thus not handle the last line if it is not terminated by a newline character. Piping a variable directly in the while loop do this job and the last test appear. Signed-off-by: Erwann Roussy <[email protected]>
dupremathieu
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed that the last test of each category wasn't displayed in the report. The problem was obviously a mistake in a loop that doesn't handle the last test.
In fact, the while loop reading test cases uses bash process substitution which is a bad idea. This method split lines on newline character and will thus not handle the last line if it is not terminated by a newline character.
Piping a variable directly in the while loop do this job and the last test appear.