Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report generator as submodule debian #50

Merged
merged 7 commits into from
Jan 12, 2024

Conversation

eroussy
Copy link
Member

@eroussy eroussy commented Jan 11, 2024

No description provided.

@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch from 159005f to 1b6f3d3 Compare January 11, 2024 11:54
@eroussy eroussy marked this pull request as ready for review January 11, 2024 13:39
@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch from 1b6f3d3 to 98620ad Compare January 11, 2024 13:44
@eroussy eroussy linked an issue Jan 11, 2024 that may be closed by this pull request
@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch from 98620ad to 25ea09f Compare January 11, 2024 14:24
launch.sh Outdated
cd "${WORK_DIR}/ci/test-report-pdf"
rm -rf themes
mv ../seapath-themes themes
mv themes/theme.yml themes/sfl-theme.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

launch-yocto.sh Outdated
cd "${WORK_DIR}/ci/test-report-pdf"
rm -rf themes
mv ../seapath-themes themes
mv themes/theme.yml themes/sfl-theme.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to keep here the sfl theme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sfl theme is provided by test-report-pdf.
Here, i replace it by the seapath theme, but it is not clear. lets change these lines.

Copy link
Member

@Paullgk Paullgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your commit message:

This prepares the removal of the report-generator directory.
Every file regarding latency results are move out.

Should be:

This prepare the removal of the report-generator directory.
Every files regarding latency results are move out.

@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch from 25ea09f to 02b81fa Compare January 12, 2024 11:20
This prepare the removal of the report-generator directory.
Every file regarding latency results are move out.

Signed-off-by: Erwann Roussy <[email protected]>
@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch 2 times, most recently from 27c222d to e8e24b2 Compare January 12, 2024 12:00
Move the report generation to test-report-pdf.

This includes to do a trick with the latency results.
Because they have to be printed at the end of the report, the adoc file
containing the part about the latency results is copied in
test-report-pdf under the name "notes.adoc".
By doing so, this file will be detected by test-report-pdf and put at
the end.

Signed-off-by: Erwann Roussy <[email protected]>
This directory contains the theme and logo for the first page of the
report.
It will replace the default one in test-report-generator.

Signed-off-by: Erwann Roussy <[email protected]>
Otherwise, the default SFL theme is used.

Signed-off-by: Erwann Roussy <[email protected]>
Both debian and yocto version now use test-report-pdf.
This directory is not useful anymore.

Signed-off-by: Erwann Roussy <[email protected]>
The GPLv3 liscence was added for the report-generation part.
As it is now as a submodule, the rest of the CI is only Apache-2

Signed-off-by: Erwann Roussy <[email protected]>
@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch from e8e24b2 to f05b019 Compare January 12, 2024 13:23
Correct the location of the png files that has been modified when
switching to test-report-pdf.
Also correct the name of the publisher test file.

Signed-off-by: Erwann Roussy <[email protected]>
@eroussy eroussy force-pushed the report-generator-as-submodule-debian branch from f05b019 to 535e6a2 Compare January 12, 2024 14:31
@eroussy eroussy merged commit f57761a into main Jan 12, 2024
1 check passed
@eroussy eroussy deleted the report-generator-as-submodule-debian branch January 12, 2024 15:12
@eroussy eroussy linked an issue Jan 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix latency tests image import in the report Fetch the report generator code from the repository
2 participants