Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the USERCUSTOMIZATION class and allow User-defined classes #107

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

insatomcat
Copy link
Member

@insatomcat insatomcat commented Jun 17, 2024

Add the USERCUSTOMIZATION class to facilitate user configuration

This commits splits the base hierarchy into 3:

  • srv_fai_config is still the default SEAPATH configuration
  • usercustomization is the same hierarchy but git will not track it, and the user can put custom files in it
  • build_tmp is a temporary folder where the installer will merge srv_fai_config and userconfiguration just before merging

srv_fai_config also includes now the new USERCUSTOMIZATION class, so that the files in the usercustomization/ folder can implement this class and override/add any setting.


Allows userdefined classes

With this commit the user can add his own classes by:

  • adding the class in the user_classes.conf file
  • dealing with a numbered script in usercustomization/class/ folder (for example usercustomization/class/99-custom, chmod 755) to use the class
  • adding all the files related to the classes in the usercustomization hierarchy

@insatomcat insatomcat requested a review from eroussy June 17, 2024 09:27
@insatomcat insatomcat force-pushed the usercustom branch 6 times, most recently from 61818d6 to 42c3f14 Compare June 17, 2024 09:46
@insatomcat insatomcat force-pushed the usercustom branch 2 times, most recently from 08d02af to 7140686 Compare June 17, 2024 10:23
This commits splits the base hierarchy into 3:
- srv_fai_config is still the default SEAPATH configuration
- usercustomization is the same hierarchy but git will not track it, and the user can put custom files in it
- build_tmp is a temporary folder where the installer will merge srv_fai_config and usercustomization just before merging

srv_fai_config also includes now the new USERCUSTOMIZATION class, so that the files in the userconfiguration/ folder can implement this class and override/add any setting.

Signed-off-by: Florent CARLI <[email protected]>
With this commit the user can add his own classes by:
- adding the class in the user_classes.conf file
- dealing with a numbered script in usercustomization/class/ folder (for example usercustomization/class/99-custom, chmod 755) to use the class
- adding all the files related to the classes in the usercustomization hierarchy

Signed-off-by: Florent CARLI <[email protected]>
@insatomcat insatomcat changed the title Add the USERCUSTOMIZATION class to facilitate user configuration Add the USERCUSTOMIZATION class and allow User-defined classes Jun 17, 2024
@insatomcat insatomcat marked this pull request as ready for review June 17, 2024 16:41
@insatomcat insatomcat merged commit a7248fe into whiptail Jun 17, 2024
1 check passed
@insatomcat insatomcat deleted the usercustom branch June 17, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant