This repository has been archived by the owner on Nov 27, 2024. It is now read-only.
Telopt event #64
Open
Telopt event #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to solve what I view is an issue with the current library - the application has no idea when the telopt status changed! It has to maintain a separate tracker for when WILL / DO / DONT/ WONT was sent... and has no way to check the telnet_t's internal state when it receives a TELNET_EV_WILL, etc.
By adding in new events, now the application can know how to react.
I decided to create this after realizing that there was no simple way to know when the server has enabled MCCP2 so that it can know when to send an IAC SB MCCP2 IAC SE.
If I have overlooked something major please let me know.