Skip to content

fix: Paginator API improvements #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

fix: Paginator API improvements #297

merged 5 commits into from
Apr 28, 2025

Conversation

andrii-balitskyi
Copy link
Collaborator

@andrii-balitskyi andrii-balitskyi commented Apr 16, 2025 •
edited
Loading

  • improve var naming
  • nextPage method should throw on null $next_page_cursor arg
  • add on_response callback param only to list methods that define page_cursor

@andrii-balitskyi andrii-balitskyi self-assigned this Apr 17, 2025
@andrii-balitskyi andrii-balitskyi merged commit 21c8413 into main Apr 28, 2025
7 checks passed
@andrii-balitskyi andrii-balitskyi deleted the paginator-improvements branch April 28, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razor-x razor-x razor-x approved these changes

@rchodava rchodava Awaiting requested review from rchodava

Assignees

@andrii-balitskyi andrii-balitskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrii-balitskyi @razor-x @seambot