Skip to content

vm_arm: move vpci code to dedicated module #77

Draft
axel-h wants to merge 1 commit intoseL4:masterfrom
Hensoldt-Cyber:patch-axel-17
Draft

vm_arm: move vpci code to dedicated module #77
axel-h wants to merge 1 commit intoseL4:masterfrom
Hensoldt-Cyber:patch-axel-17

Conversation

@axel-h
Copy link
Member

@axel-h axel-h commented Mar 31, 2023

This PR is on top of #73 and uses the DTB generation refactoring to move the vpci support imto a dedicate module.

@axel-h axel-h requested a review from chrisguikema March 31, 2023 13:20
@axel-h axel-h mentioned this pull request Mar 31, 2023
Merged
@axel-h axel-h force-pushed the patch-axel-17 branch 6 times, most recently from eb3b93e to 3d0f7eb Compare April 6, 2023 16:44
@axel-h axel-h force-pushed the patch-axel-17 branch 5 times, most recently from 87d3791 to cf9e982 Compare April 10, 2023 20:41
@axel-h axel-h force-pushed the patch-axel-17 branch 4 times, most recently from 7003abc to 15b2e52 Compare April 20, 2023 11:23
@axel-h axel-h force-pushed the patch-axel-17 branch 2 times, most recently from 9a076cb to ea91d57 Compare May 7, 2023 22:00
@axel-h axel-h force-pushed the patch-axel-17 branch 2 times, most recently from 19b1cc5 to ab9f0fa Compare May 25, 2023 10:22
@hlyytine
Copy link
Contributor

hlyytine commented Jun 3, 2023

I'm working on generalizing that cross-VM connector. My intention is to support mapping as RAM and providing MMIO-style interface in addition to that PCI interface. So perhaps crossvm.c should not depend on PCI support that hard.

@axel-h
Copy link
Member Author

axel-h commented Jun 6, 2023

I'm working on generalizing that cross-VM connector. My intention is to support mapping as RAM and providing MMIO-style interface in addition to that PCI interface. So perhaps crossvm.c should not depend on PCI support that hard.

It would take another PR for this file to relax the dependency then. At the moment that seem a big practical dependency, that is why I made this change.

@axel-h axel-h force-pushed the patch-axel-17 branch 2 times, most recently from 88d4360 to 13053c8 Compare June 6, 2023 16:20
@axel-h
Copy link
Member Author

axel-h commented Jun 6, 2023

After some more refactoring, making a VPCI module seems not really useful, as this would be just a wrapper around the vPCI helper coede in libsel4vmmplatsupport then. The refactoring seem an improvement, though.

@axel-h axel-h force-pushed the patch-axel-17 branch 3 times, most recently from 2800ade to c33c7e4 Compare June 6, 2023 16:43
@axel-h axel-h force-pushed the patch-axel-17 branch 3 times, most recently from ec9db48 to f3ad38d Compare January 25, 2024 15:23
vm_arm: move vpci code to dedicated module
67b77de 
This calls vmm_pci_init() only when vpci is enabled.

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisguikema chrisguikema Awaiting requested review from chrisguikema

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@axel-h @hlyytine