HMA defaults to norm distribution for child tables #2710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
=======================================
Coverage 98.16% 98.16%
=======================================
Files 72 72
Lines 7830 7843 +13
=======================================
+ Hits 7686 7699 +13
Misses 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rwedge
changed the title
rwedge
force-pushed
the
issue-2665-norm-child-tables
branch
from
70623eb to
fc6b9d7
Compare
rwedge
commented
Oct 16, 2025
| num_data_columns = columns_per_table[table_name] | ||
| if num_data_columns == 0: | ||
| # no parameter columns are generated if there are no data or extended columns | ||
| num_data_columns = columns_per_table[table_name][0] |
There was a problem hiding this comment.
Does changing the meaning of data_columns to be a subset of the former data_columns seem reasonable?
rwedge
commented
Oct 16, 2025
sdv/multi_table/hma.py
Outdated
| ) | ||
|
|
||
| return columns_per_table | ||
| return {key: sum(value) for key, value in columns_per_table.items()} |
There was a problem hiding this comment.
replace key and value with table_name and columns_list
rwedge
force-pushed
the
issue-2665-norm-child-tables
branch
from
fc6b9d7 to
d1a4afe
Compare
frances-h
approved these changes
Oct 22, 2025
fealho
approved these changes
Oct 24, 2025
rwedge
force-pushed
the
issue-2665-norm-child-tables
branch
from
d1a4afe to
101a8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2665
CU-86b6gwz0p