Skip to content

Conversation

@fealho
Copy link
Member

@fealho fealho commented Oct 6, 2025

CU-86b6fugf3, Resolve #2661
CU-86b6fugf3, Resolve #2663
CU-86b6xkdcf, Resolve #2686
CU-86b6xjuk7, Resolve #2685
CU-86b6xjugh, Resolve #2684
CU-86b6xrcb1, Resolve #2689
CU-86b6xrqf0, Resolve #2691
CU-86b6xnx26, Resolve #2687
CU-86b6xp7a0, Resolve #2688
CU-86b6xrcah, Resolve #2690

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 96.31336% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.12%. Comparing base (926c0b4) to head (da3c9e2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdv/datasets/demo.py 96.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2705      +/-   ##
==========================================
- Coverage   98.16%   98.12%   -0.04%     
==========================================
  Files          72       72              
  Lines        7830     7993     +163     
==========================================
+ Hits         7686     7843     +157     
- Misses        144      150       +6     
Flag Coverage Δ
integration 75.60% <58.98%> (-0.72%) ⬇️
unit 96.84% <92.62%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fealho fealho marked this pull request as ready for review October 16, 2025 16:44
@fealho fealho requested a review from a team as a code owner October 16, 2025 16:44
@fealho fealho requested review from sarahmish and removed request for a team October 16, 2025 16:44
@fealho fealho requested review from amontanez24 and pvk-developer and removed request for sarahmish October 16, 2025 16:45
@fealho fealho requested a review from pvk-developer October 17, 2025 16:59
@fealho fealho force-pushed the feature-branch-download-demo branch from 80cfbdb to 78fee6b Compare October 17, 2025 17:02
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the test datasets you created from the buckets. I think that caused some test failures. Can we use datasets that are actually in the bucket?

@amontanez24
Copy link
Contributor

Please rebase and merge when you merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment