Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support multiple expected outputs in the test program #42

Merged
merged 15 commits into from
Jun 25, 2024

Conversation

logic-finder
Copy link
Contributor

@logic-finder logic-finder commented Jun 22, 2024

(1) PAINSTAKING refactoring (nearly rewriting)
(2) support multiple expected output: a testcase is evaluated as successful if at least one expected output is equivalent to the actual output.

@logic-finder logic-finder marked this pull request as draft June 22, 2024 14:59
@lshqqytiger lshqqytiger added the enhancement New feature or request label Jun 22, 2024
@logic-finder logic-finder changed the title [Enhancement] Support multi expected outputs in the test program [Enhancement] Support multiple expected outputs in the test program Jun 22, 2024
@logic-finder logic-finder force-pushed the lf/support-multi-output branch from 5f697b9 to d34a037 Compare June 22, 2024 18:26
@logic-finder logic-finder requested a review from lshqqytiger June 22, 2024 18:26
@logic-finder logic-finder marked this pull request as ready for review June 22, 2024 18:31
@lshqqytiger
Copy link
Contributor

Please check CI status.

Copy link
Contributor

@lshqqytiger lshqqytiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review. Review will be continued if this PR passes CI.

@logic-finder logic-finder requested a review from lshqqytiger June 23, 2024 16:34
Copy link
Contributor

@lshqqytiger lshqqytiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@logic-finder logic-finder requested a review from lshqqytiger June 24, 2024 20:09
Copy link
Contributor

@lshqqytiger lshqqytiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lshqqytiger lshqqytiger merged commit cef7de1 into main Jun 25, 2024
17 checks passed
@logic-finder logic-finder deleted the lf/support-multi-output branch June 25, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants