Skip to content

Commit

Permalink
Extend ScyllaCluster rollout timeout in E2E
Browse files Browse the repository at this point in the history
Rollout timeout didn't take into account time required to
schedule and complete cleanup Jobs.
  • Loading branch information
zimnx committed Dec 12, 2023
1 parent 405f111 commit 16f7f13
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions test/e2e/utils/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const (
SyncTimeout = 2 * time.Minute
imagePullTimeout = 4 * time.Minute
joinClusterTimeout = 3 * time.Minute
cleanupJobTimeout = 1 * time.Minute

// memberRolloutTimeout is the maximum amount of time it takes to start a scylla pod and become ready.
// It includes the time to pull the images, copy the necessary files (sidecar), join the cluster and similar.
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/utils/helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func IsNodeConfigDoneWithNodeTuningFunc(nodes []*corev1.Node) func(nc *scyllav1a
}

func RolloutTimeoutForScyllaCluster(sc *scyllav1.ScyllaCluster) time.Duration {
return SyncTimeout + time.Duration(GetMemberCount(sc))*memberRolloutTimeout
return SyncTimeout + time.Duration(GetMemberCount(sc))*memberRolloutTimeout + cleanupJobTimeout
}

func GetMemberCount(sc *scyllav1.ScyllaCluster) int32 {
Expand Down

0 comments on commit 16f7f13

Please sign in to comment.