Conversation
BRANCHES already lists every release branch that exists upstream, so no release is left to register and /stable/ stays at scylla-4.19.0.x, frozen four months before client routes landed. Publish scylla-4.x and make it LATEST_VERSION, matching gocql and cpp-driver, which both publish their development branch as stable. /stable/ now carries upgrade_guide/from_3x/, so the deprecation banner's migration link points straight at it, as its comment anticipated. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
scylla-3.x is not in BRANCHES, so the newest published 3.x docs come from scylla-3.11.5.x, frozen 2025-06-02. Nothing written on the maintenance branch reaches the site, and no tag carries it either -- the deprecation notice from scylladb#919 has no published home. Publish it, and mark it deprecated so it keeps the caution banner. hide_version_dropdown already lists it, so it stays out of the version selector: reachable by URL and search, not advertised. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scylla-3.xis not inBRANCHES, so the newest published 3.x docs come fromscylla-3.11.5.x, frozen 2025-06-02. Nothing written on the maintenance branch reaches java-driver.docs.scylladb.com, and no release will carry it there either: no tag contains the 3.x deprecation notice from #919 (scylla-3.xis 5 commits past3.11.5.18), and no 3.x release branch has been cut since.scylla-3.xtoBRANCHES.DEPRECATED_VERSIONS, so it keeps the caution banner from_templates/version-warning.html.scylladb_markdown_recommonmark_versions— omission is what selects MyST, which its```{eval-rst}fences need.hide_version_dropdowninhtml_theme_optionshas listedscylla-3.xsince the docs tree was ported from that branch, so this publishes without adding an entry to the version selector. That is the right outcome for a deprecated line: reachable by URL and by search, not advertised.scylla-3.xis a Java 8 build (<jdk>[1.8,)</jdk>) and #1004's per-branch javadoc map defaults unknown versions to JDK 11, soscylla-3.xhas to be added to its JDK 8 arm before this merges or its javadoc will fail. I've flagged it there.Verified:
make -C docs testgreen under-W --keep-going;sphinx-multiversion --dump-metadatalists 18 versions withscylla-3.xamong them;multiversion_regex_builder(BRANCHES)matches it andDEPRECATED_VERSIONScontains it. Not covered: the full 18-version publish, which only runs post-merge.Stacked on #1079 — its commit shows in this diff until that merges. Both wait on #1004.
Fixes DRIVER-1083
🤖 Generated with Claude Code