-
Notifications
You must be signed in to change notification settings - Fork 96
Numba warning fix #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Numba warning fix #1002
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1002 +/- ##
==========================================
- Coverage 69.99% 66.63% -3.36%
==========================================
Files 39 40 +1
Lines 5532 6060 +528
Branches 1037 1015 -22
==========================================
+ Hits 3872 4038 +166
- Misses 1367 1662 +295
- Partials 293 360 +67
🚀 New features to boost your workflow:
|
To catch this sort of thing, the project should use the |
So in this PR, you could also add to the
or do it locally and go one-by-one and catch any others that exist |
I think it might need to be a double colon: https://docs.pytest.org/en/stable/how-to/capture-warnings.html#controlling-warnings sorry for the mistype |
Fixes: #994
Without the fix this is the warning I get in a notebook:
I don't think it is possible to add a test case because in theory that part of the code is unreachable