uniform color handling between labels and points/shapes #497
+49
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 83.80% 83.83% +0.03%
==========================================
Files 8 8
Lines 1976 1980 +4
==========================================
+ Hits 1656 1660 +4
Misses 320 320
🚀 New features to boost your workflow:
|
timtreis
reviewed
Oct 20, 2025
|
|
||
| # element_params[el]["color"] = None # TODO: delete | ||
| # color = param_dict["color"] | ||
| # if color is not None: |
There was a problem hiding this comment.
Is this still in debugging or ready @Sonja-Stockhaus ?
There was a problem hiding this comment.
It's ready for tests and I think I wanted to remove the comments afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #478, here we adapt the color handling of labels so that it works the same way as points/shapes (e.g. you can pass any color like...)