Skip to content

Conversation

@LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Aug 11, 2025

Contribution guide for spatialdata-io.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.06%. Comparing base (7c19850) to head (595eea7).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #315       +/-   ##
===========================================
+ Coverage   38.75%   49.06%   +10.30%     
===========================================
  Files          26       26               
  Lines        2709     2686       -23     
===========================================
+ Hits         1050     1318      +268     
+ Misses       1659     1368      -291     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaMarconato
Copy link
Member Author

LucaMarconato commented Sep 5, 2025

3.11 will work again when this is merged (and released): scverse/spatialdata#969, it's probably due to too restrictive constraints, that we relax in that PR.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some high-level thoughts:

  • I've marked a few grammatical issues that appear elsewhere in the same document but refrained from spamming.
  • My main though would be to be very careful with private delivery of data or code. Plan this for the long-term. Get a license!
  • There are some sections that are complicated and could use work, but in general this is great, and I'd suggest getting it in and then iterating on it with real user feedback. (Not a fake like me 😉)

@LucaMarconato LucaMarconato marked this pull request as ready for review September 8, 2025 12:31
@LucaMarconato
Copy link
Member Author

Thanks @joshmoore! I followed your suggestions and applied the required corrections.

@LucaMarconato LucaMarconato merged commit 531769a into scverse:main Sep 8, 2025
4 of 5 checks passed
@LucaMarconato LucaMarconato deleted the contribution-guide branch September 8, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants