-
Notifications
You must be signed in to change notification settings - Fork 48
Contribution guide #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution guide #315
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
===========================================
+ Coverage 38.75% 49.06% +10.30%
===========================================
Files 26 26
Lines 2709 2686 -23
===========================================
+ Hits 1050 1318 +268
+ Misses 1659 1368 -291 🚀 New features to boost your workflow:
|
|
3.11 will work again when this is merged (and released): scverse/spatialdata#969, it's probably due to too restrictive constraints, that we relax in that PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some high-level thoughts:
- I've marked a few grammatical issues that appear elsewhere in the same document but refrained from spamming.
- My main though would be to be very careful with private delivery of data or code. Plan this for the long-term. Get a license!
- There are some sections that are complicated and could use work, but in general this is great, and I'd suggest getting it in and then iterating on it with real user feedback. (Not a fake like me 😉)
Co-authored-by: Josh Moore <[email protected]>
Co-authored-by: Josh Moore <[email protected]>
|
Thanks @joshmoore! I followed your suggestions and applied the required corrections. |
Contribution guide for
spatialdata-io.