Add score per million normalization when merging peaks #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'm aware of this approach. But I'm not particularly interested in merging this feature now as I do not think this is the best way for solving this problem. |
|
Hi Kai and Gilbert, Probably not the best place for this and happy to move it to a discussion, but thought I'd chime in since I'm dealing with this problem with a dataset. Have you considered giving an option for downsampling fragments to some uniform or maximum depth prior to peak calling? Is there any easy way to accomplish this with the current version of the tool? Kai, I'm also curious if you have a best way of dealing with this in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, read depth or quality in cell types / samples may vary, which affect peak calling. Peak normalization introduced in this paper may help