Skip to content

Remove thiserror #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2023
Merged

Remove thiserror #419

merged 4 commits into from
Jan 5, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Jan 5, 2023 •
edited
Loading

  • remove this error and replace with derive_more where possible. This should declutter some overly verbose error messages. Better for no_std environments.
  • clean up some unused error values
  • remove generic Result in ws client - not used anyway and makes it more complex than necessary

closes #317

@haerdib haerdib self-assigned this Jan 5, 2023
@haerdib haerdib added F6-optimization This should optimize the performance E2-breaksapi labels Jan 5, 2023
@haerdib haerdib changed the title Remove this error Remove thiserror Jan 5, 2023
@haerdib haerdib marked this pull request as ready for review January 5, 2023 14:47
@haerdib haerdib requested a review from Niederb January 5, 2023 14:47
Niederb
Niederb approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍 I like the cleanup for the Errors and that they now have more specific names.
I also learned about derive_more which makes this PR even better 😸

@haerdib haerdib merged commit c12db80 into master Jan 5, 2023
@haerdib haerdib deleted the bh/317-remove-this-error branch January 5, 2023 15:24
haerdib added a commit that referenced this pull request Jan 6, 2023
@haerdib
add signer
7a74edb 
wohoo

fix most

finally compiling

make clippy happy

remove unused comment

update comment

Fix documentation for running an example (#417)

Also some minor typos

clean up imports of macors

Remove thiserror and use more specific Error names (#419)

* small result clean up

* lets not overcomplicate

* remove thiserror

* remove unused errors
haerdib added a commit that referenced this pull request Jan 9, 2023
@haerdib @dependabot
add signer
e779049 
wohoo

fix most

finally compiling

make clippy happy

remove unused comment

update comment

Fix documentation for running an example (#417)

Also some minor typos

clean up imports of macors

Remove thiserror and use more specific Error names (#419)

* small result clean up

* lets not overcomplicate

* remove thiserror

* remove unused errors

fix build

Bump tokio from 1.23.0 to 1.23.1 (#427)

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib added a commit that referenced this pull request Jan 9, 2023
@haerdib @dependabot
add signer
c78c41d 
wohoo

fix most

finally compiling

make clippy happy

remove unused comment

update comment

Fix documentation for running an example (#417)

Also some minor typos

clean up imports of macors

Remove thiserror and use more specific Error names (#419)

* small result clean up

* lets not overcomplicate

* remove thiserror

* remove unused errors

fix build

Bump tokio from 1.23.0 to 1.23.1 (#427)

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib added a commit that referenced this pull request Jan 11, 2023
@haerdib @dependabot
add signer
454b89b 
wohoo

fix most

finally compiling

make clippy happy

remove unused comment

update comment

Fix documentation for running an example (#417)

Also some minor typos

clean up imports of macors

Remove thiserror and use more specific Error names (#419)

* small result clean up

* lets not overcomplicate

* remove thiserror

* remove unused errors

fix build

Bump tokio from 1.23.0 to 1.23.1 (#427)

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib added a commit that referenced this pull request Jan 11, 2023
@haerdib @dependabot
Make UncheckedExtrinsicV4 generic (#418)
027ed59 
* add signer

wohoo

fix most

finally compiling

make clippy happy

remove unused comment

update comment

Fix documentation for running an example (#417)

Also some minor typos

clean up imports of macors

Remove thiserror and use more specific Error names (#419)

* small result clean up

* lets not overcomplicate

* remove thiserror

* remove unused errors

fix build

Bump tokio from 1.23.0 to 1.23.1 (#427)

Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1.
- [Release notes](https://github.com/tokio-rs/tokio/releases)
- [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1)

---
updated-dependencies:
- dependency-name: tokio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* redo rebase errors

* define new type for <.. as Trait>

* remove doubl into and comments

* fix rebase errors

* fix comments

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niederb Niederb Niederb approved these changes

Assignees

@haerdib haerdib

Labels
E2-breaksapi F6-optimization This should optimize the performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up errors: use this_error in no_std or remove completely
2 participants
@haerdib @Niederb