ci: upgrade rust base image and build secret-contract-optimizer in GitHub Workflows #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-regalia
requested review from
Cashmaney,
toml01,
liorbond and
valdok
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the rust base image used by the secret-contract-optimizer from v1.71.0 to v1.83.0.
It also adds a job to the GitHub ci.yaml workflow to build and push this image to scrtlab's ghcr.io. Please note that I used
push: trueon the "Build SecretContractOptimizer" step but testing/modification may be required to authenticate when pushing.EDIT: I also simply used
{{ github.ref_name }}for the build tag, which will keep it aligned with the network version but not sure if this is desired or not.