This repository was archived by the owner on Apr 18, 2025. It is now read-only.
forked from privacy-scaling-explorations/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 392
FEAT: parallelize witness assignment of bytecode circuit using assign_regions api #530
Open
Velaciela
wants to merge
13
commits into
develop
Choose a base branch
from
parallel_bytecode_assign
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunxian-xia
reviewed
Jun 9, 2023
zkevm-circuits/src/bytecode_circuit/circuit/to_poseidon_hash.rs
Outdated
Show resolved
Hide resolved
a62b586
to
ec5d89f
Compare
kunxian-xia
reviewed
Jun 13, 2023
kunxian-xia
reviewed
Jun 15, 2023
zkevm-circuits/src/bytecode_circuit/circuit/to_poseidon_hash.rs
Outdated
Show resolved
Hide resolved
12 tasks
we need to merge scroll-tech/halo2#50 before we can pass all unit tests |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
split and parallelize the time-consuming part of bytecode circuit assignment by using
assign_regions()
uint test:
Feature:
scroll
andparallel_syn
is required and cannot be executed together with regular unit tests,This patch adds
Run parallel assignment tests
into CI workflowsuper circuict benchmarking in scroll-zkevm:
Before: 21.000s
Now: 0.952s
Speedup: 22x
Since the multi-phase num is 3, the above assignment will be executed three times,
so this patch reduce the time of witness generation(super circuit) by ~60s (20s x 3)
Notes
In super circuit (v0.4), bytecode circuit has
28
witness instancesWhen using
assign_regions()
for parallel execution, the load is unbalanced(min: 1, max: 24498)but further optimization yields less, so here is just a log of profiling result